Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): nzCalendarChange not work when clicking ok #5790

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 16, 2020

Fixes #5782

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #5790 into master will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5790   +/-   ##
=======================================
  Coverage   90.09%   90.10%           
=======================================
  Files         455      455           
  Lines       13857    13840   -17     
  Branches     2185     2184    -1     
=======================================
- Hits        12485    12470   -15     
+ Misses        849      846    -3     
- Partials      523      524    +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.81% <50.00%> (-0.78%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.07% <100.00%> (+1.07%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-1.42%) ⬇️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️
components/core/tree/nz-tree-base-node.ts 67.39% <0.00%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a58fd...c5a02db. Read the comment docs.

@wenqi73 wenqi73 force-pushed the fix-calendar-change branch from de45676 to c5a02db Compare September 16, 2020 08:57
@wenqi73 wenqi73 requested a review from hsuanxyz September 16, 2020 09:22
@wenqi73 wenqi73 merged commit c9426f0 into NG-ZORRO:master Sep 18, 2020
@wenqi73 wenqi73 deleted the fix-calendar-change branch September 18, 2020 09:45
@github-actions
Copy link

github-actions bot commented Sep 18, 2020

😭 Deploy PR Preview c9426f0 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzOnCalendarChange event not being emitted on nz-range-picker with time
2 participants