reflector(moment): remove the dependency of moment

[vthinkxie]

What problem does this feature solve?

reduce the package size since angular has provided all the locales we need

What does the proposed API look like?

may bring some break changes.

[trotyl]

Draft design doc for anyone works on this

Background

Angular has dropped dependency of Intl API and uses self-provided locale data extracted from CLDR starts from v5.

Usage

An Angular application needs to define which locale to support by registering the locale data, like:

import { registerLocaleData } from '@angular/common';
import localeFr from '@angular/common/locales/fr';
import localeZh from '@angular/common/locales/zh';

// the second parameter 'fr', 'zh' are optional
registerLocaleData(localeFr, 'fr');
registerLocaleData(localeFr, 'zh');

More details can be found in Angular i18n doc.

All registered locale data would be available in runtime. Then the application needs to provide the LOCALE_ID somehow, for example by CLI option at build time or using navigator.language at runtime. _{(Or whatever methods like url path, that's not decided by library)}

But the library should provide an option to override LOCALE_ID as the DI result cannot be changed after setup. _{(Which can be a separate work)}

Implementation

For template formatting, just use the DatePipe, it will automatically use the locale provided by LOCALE_ID token, also there is a locale parameter to override it.

For logic formatting, Angular would provide something like LocaleService in 5.2 or 5.3, but before that (being our minimal requirement), we need to make it work for current infrastructure. The easiest way to do is the pipe as a service pattern (should use pipe directly when possible), like:

@NgModule({
  providers: [ DatePipe ]
})
class LocaleModule { }

@Injectable()
class LocaleService {
  constructor(private datePipe: DatePipe) { }

  formatDate(date: Date, format: string, locale: string): string {
    return this.datePipe.transform(date, format, /* timezone */ undefined, locale);
  }
}

For other utilities like plus one day, can be achieved by some tiny 3rd-party libraries like date-fns. But could still have some problem for typing in CommonJS module integration. _{(Should only import the exact helpers for size consideration)}

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.