-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:popconfirm): support popconfirm template context #7989
feat(module:popconfirm): support popconfirm template context #7989
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7989 +/- ##
==========================================
+ Coverage 91.49% 91.50% +0.01%
==========================================
Files 534 534
Lines 18425 18427 +2
Branches 2815 2815
==========================================
+ Hits 16858 16862 +4
+ Misses 1246 1245 -1
+ Partials 321 320 -1 ☔ View full report in Codecov by Sentry. |
hi there, pipeline would fail once i update relative doc, so i just reverted it @wzhudev |
hey @yuhengzhouz, sorry for review this pr too late, it'll be great if you'd like to resolve the conflicts |
391811e
to
74540e6
Compare
hi there, all done @Laffery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will merge this pr in v18.1
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7606
What is the new behavior?
nzPopconfirmTitleContext can be passed in and used by nzPopconfirmTitle
Does this PR introduce a breaking change?
Other information