Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:popconfirm): support popconfirm template context #7989

Merged

Conversation

yuhengzhouz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7606

What is the new behavior?

nzPopconfirmTitleContext can be passed in and used by nzPopconfirmTitle

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 20, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (512a577) to head (e2cfb0b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7989      +/-   ##
==========================================
+ Coverage   91.49%   91.50%   +0.01%     
==========================================
  Files         534      534              
  Lines       18425    18427       +2     
  Branches     2815     2815              
==========================================
+ Hits        16858    16862       +4     
+ Misses       1246     1245       -1     
+ Partials      321      320       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhengzhouz
Copy link
Contributor Author

hi there, pipeline would fail once i update relative doc, so i just reverted it @wzhudev

@Laffery
Copy link
Collaborator

Laffery commented May 29, 2024

hey @yuhengzhouz, sorry for review this pr too late, it'll be great if you'd like to resolve the conflicts

@Laffery Laffery changed the title Support popconfirm template context feat(module:popconfirm): support popconfirm template context May 29, 2024
@yuhengzhouz yuhengzhouz force-pushed the support-popconfirm-template-context branch from 391811e to 74540e6 Compare June 10, 2024 02:29
@yuhengzhouz
Copy link
Contributor Author

hi there, all done @Laffery

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will merge this pr in v18.1

@Laffery Laffery added this to the v18.1 milestone Jun 30, 2024
@Laffery Laffery merged commit 6d27073 into NG-ZORRO:master Jul 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants