Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:sider): fix typo isSiderTrgger to isSiderTrigger #1434

Merged
merged 1 commit into from
May 17, 2018

Conversation

lmsreborn
Copy link
Contributor

@lmsreborn lmsreborn commented May 14, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

fix typo in nz-sider component

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #1434 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         196      196           
  Lines        8368     8368           
  Branches     1106     1106           
=======================================
  Hits         8112     8112           
  Misses         36       36           
  Partials      220      220
Impacted Files Coverage Δ
components/layout/nz-sider.component.ts 96.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a06694...d06009b. Read the comment docs.

@vthinkxie vthinkxie merged commit f1f26ad into NG-ZORRO:master May 17, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants