Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): support default filter #1893

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 28, 2018

close #1872

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1872

What is the new behavior?

Users can name some filters as default.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev requested a review from vthinkxie July 28, 2018 07:31
@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #1893 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +0.01%     
==========================================
  Files         468      468              
  Lines       11242    11252      +10     
  Branches     1474     1479       +5     
==========================================
+ Hits        10787    10798      +11     
  Misses        131      131              
+ Partials      324      323       -1
Impacted Files Coverage Δ
components/table/nz-th.component.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabset.component.ts 96.58% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f5625...439b65f. Read the comment docs.

@wzhudev wzhudev force-pushed the table-filter branch 3 times, most recently from fc2e503 to cc5698f Compare July 28, 2018 12:21
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byDefault should not emit data

@vthinkxie vthinkxie merged commit cea0e51 into NG-ZORRO:master Aug 3, 2018
@wzhudev wzhudev deleted the table-filter branch August 20, 2018 11:21
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set initial filter to nz-table component
2 participants