feat(layout:sider): support for custom trigger with nzCollapsedWidth set to 0 #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthinkxie
requested changes
Sep 17, 2018
|
@vthinkxie I tried to add some tests but couldn't make them work properly as I'm not very familiar with your testing environment. I pushed the current state of my tests, hoping you can fix them. |
vthinkxie
reviewed
Sep 17, 2018
|
Hi @Supamiu would you plz rebase this pr onto master, and the test ci goes wrong, plz check it, thanks. |
|
Hi, I'm really sorry I didn't get time to finish the tests, couldn't make them work with the custom sider icon. Do you have a guide or something about your unit tests so I could check how to implement them properly? Or if you have a bit of time, I could use a small review on them just in case you see what I did wrong. |
|
don't worry about this, I just take it over, thanks for your pr! |
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:layout): support zeroTrigger close NG-ZORRO#1950 close NG-ZORRO#1951 * fix(module:layout): fix runoutside
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:layout): support zeroTrigger close NG-ZORRO#1950 close NG-ZORRO#1951 * fix(module:layout): fix runoutside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1950
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1950
What is the new behavior?
You can now set a custom trigger tof rth trigger shown when you have a nzCollapsedWidth set to 0 on
Does this PR introduce a breaking change?
Other information