Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:i18n): update missing fields in fr_FR(NG-ZORRO#2586) #2737

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

dingjules
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

support fr-FR for NzI18nService.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 27e8b73

https://deploy-preview-2737--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #2737 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2737   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         507      507           
  Lines       12086    12086           
  Branches     1701     1701           
=======================================
  Hits        11551    11551           
  Misses        171      171           
  Partials      364      364
Impacted Files Coverage Δ
components/i18n/languages/fr_FR.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6554cf5...27e8b73. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit c821d56 into NG-ZORRO:master Jan 4, 2019
@wzhudev wzhudev mentioned this pull request Jan 4, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants