Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:affix): fix should reset placeholder size when trigger resize event #2835

Merged
merged 10 commits into from
Feb 12, 2019
Merged

fix(module:affix): fix should reset placeholder size when trigger resize event #2835

merged 10 commits into from
Feb 12, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 24, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2818

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 24, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit c5e525e

https://deploy-preview-2835--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #2835 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
+ Coverage   97.41%   97.42%   +0.01%     
==========================================
  Files         523      523              
  Lines       10951    10961      +10     
  Branches      781      781              
==========================================
+ Hits        10668    10679      +11     
+ Misses        182      181       -1     
  Partials      101      101
Impacted Files Coverage Δ
components/affix/nz-affix.component.ts 100% <100%> (ø) ⬆️
components/core/util/check.ts 91.17% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ce186...c5e525e. Read the comment docs.

@cipchk cipchk changed the title fix(module:affix): fix should reset placeholder size when trigger resize event WIP(module:affix): fix should reset placeholder size when trigger resize event Jan 24, 2019
@cipchk cipchk changed the title WIP(module:affix): fix should reset placeholder size when trigger resize event fix(module:affix): fix should reset placeholder size when trigger resize event Jan 24, 2019
@vthinkxie
Copy link
Member

@cipchk plz rebase

@vthinkxie
Copy link
Member

@cipchk it seems that you have to rebase again

vthinkxie
vthinkxie approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 7068a5e into NG-ZORRO:master Feb 12, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@cipchk @Ricbet
fix(module:affix): fix should reset placeholder size when trigger res…
6fd4808 
…ize event (NG-ZORRO#2835)

* fix(module:affix): fix should reset placeholder size when trigger resize event

- close NG-ZORRO#2818

* chore: fix test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@cipchk @vthinkxie
fix(module:affix): fix should reset placeholder size when trigger res…
5fc990d 
…ize event (NG-ZORRO#2835)

* fix(module:affix): fix should reset placeholder size when trigger resize event

- close NG-ZORRO#2818

* chore: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

affix: should be reset placeholder size when trigger resize event
2 participants
@cipchk @vthinkxie