Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add noUnusedLocals config #2959

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 23, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add noUnusedLocals to tsconfig.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev
Copy link
Member Author

wzhudev commented Feb 23, 2019

I will update code style in this sequence of pull requests too.

Please merge these pull requests as quickly as possible. Otherwise I have to rebase a lot of times...

@wzhudev wzhudev changed the title build: add noUnusedLocals config [WIP] build: add noUnusedLocals config Feb 23, 2019
@wzhudev wzhudev changed the title [WIP] build: add noUnusedLocals config build: add noUnusedLocals config Feb 23, 2019
@vthinkxie vthinkxie mentioned this pull request Feb 23, 2019
7 tasks
@netlify
Copy link

netlify bot commented Feb 23, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 87e7cab

https://deploy-preview-2959--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #2959 into master will decrease coverage by <.01%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2959      +/-   ##
==========================================
- Coverage   97.35%   97.35%   -0.01%     
==========================================
  Files         529      529              
  Lines       11094    11081      -13     
  Branches      803      803              
==========================================
- Hits        10801    10788      -13     
  Misses        183      183              
  Partials      110      110
Impacted Files Coverage Δ
components/drawer/nz-drawer.component.ts 100% <ø> (ø) ⬆️
components/anchor/nz-anchor-link.component.ts 100% <ø> (ø) ⬆️
components/modal/nz-modal.component.ts 99.5% <ø> (-0.01%) ⬇️
components/tag/nz-tag.component.ts 100% <ø> (ø) ⬆️
components/message/nz-message.service.ts 97.91% <ø> (ø) ⬆️
...omponents/calendar/nz-calendar-header.component.ts 100% <ø> (ø) ⬆️
components/slider/nz-slider-handle.component.ts 100% <ø> (ø) ⬆️
components/calendar/nz-calendar.component.ts 97.27% <ø> (-0.02%) ⬇️
...ents/time-picker/nz-time-picker-panel.component.ts 92.39% <ø> (ø) ⬆️
components/empty/nz-embed-empty.component.ts 95.91% <ø> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651e3fa...87e7cab. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 44aaa32 into NG-ZORRO:master Feb 24, 2019
@wzhudev wzhudev deleted the tsconfig branch February 24, 2019 04:30
@vthinkxie vthinkxie mentioned this pull request Mar 4, 2019
12 tasks
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants