Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree-select): support set the max count for tags #2970

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2488

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 37434d3

https://deploy-preview-2970--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2970 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   97.37%   97.37%   +<.01%     
==========================================
  Files         546      546              
  Lines       11265    11269       +4     
  Branches      809      809              
==========================================
+ Hits        10969    10973       +4     
  Misses        188      188              
  Partials      108      108
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 99.47% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ddf9d...37434d3. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 4081abb into NG-ZORRO:master Feb 26, 2019
@hsuanxyz hsuanxyz deleted the feat/tree-select-max-tag branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants