Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix children state not changed in async demo #2985

Merged
merged 3 commits into from
Feb 28, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev wzhudev requested a review from cipchk February 28, 2019 02:32
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #2985 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
+ Coverage   97.35%   97.35%   +<.01%     
==========================================
  Files         548      548              
  Lines       11436    11441       +5     
  Branches      813      813              
==========================================
+ Hits        11133    11138       +5     
  Misses        190      190              
  Partials      113      113
Impacted Files Coverage Δ
components/icon/nz-icon-test.module.ts 100% <ø> (ø) ⬆️
components/cascader/nz-cascader-li.component.ts 88.88% <100%> (+1.38%) ⬆️
components/cascader/nz-cascader.component.ts 99.23% <100%> (ø) ⬆️
components/slider/nz-slider.component.ts 94.03% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daec0ac...d928547. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d928547

https://deploy-preview-2985--ng-zorro-master.netlify.com

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一个小格式问题

components/cascader/nz-cascader-li.component.ts Outdated Show resolved Hide resolved
Co-Authored-By: wendzhue <wendzhue@gmail.com>
@wzhudev wzhudev requested a review from cipchk February 28, 2019 04:03
Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit b87e8bb into NG-ZORRO:master Feb 28, 2019
@wzhudev wzhudev deleted the cascader-async branch February 28, 2019 07:03
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…G-ZORRO#2985)

* fix(module:cascader): fix children state not changed in async demo

* build: fix ci

* Update components/cascader/nz-cascader-li.component.ts

Co-Authored-By: wendzhue <wendzhue@gmail.com>

close NG-ZORRO#2984
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#2985)

* fix(module:cascader): fix children state not changed in async demo

* build: fix ci

* Update components/cascader/nz-cascader-li.component.ts

Co-Authored-By: wendzhue <wendzhue@gmail.com>

close NG-ZORRO#2984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants