Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add noImplicitAny noImplicitThis strictFunctionTypes #3019

Closed
wants to merge 3 commits into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Please merge this after #2977.

@vthinkxie vthinkxie mentioned this pull request Mar 4, 2019
7 tasks
@wzhudev wzhudev force-pushed the tsconfig-function-types-this branch from fe81dd7 to c06374d Compare March 12, 2019 11:13
@netlify
Copy link

netlify bot commented Mar 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d6d268c

https://deploy-preview-3019--ng-zorro-master.netlify.com

@wzhudev wzhudev force-pushed the tsconfig-function-types-this branch from 0ba32ba to 54432b1 Compare March 12, 2019 15:05
@wzhudev wzhudev closed this Mar 12, 2019
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #3019 into master will decrease coverage by 35.91%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3019       +/-   ##
===========================================
- Coverage   97.32%   61.41%   -35.92%     
===========================================
  Files         550       25      -525     
  Lines       11495      609    -10886     
  Branches      817       57      -760     
===========================================
- Hits        11188      374    -10814     
- Misses        199      226       +27     
+ Partials      108        9       -99
Impacted Files Coverage Δ
components/core/util/textarea-caret-position.ts 12.76% <ø> (-36.18%) ⬇️
components/core/polyfill/request-animation.ts 17.39% <ø> (-4.35%) ⬇️
components/core/testing/type-in-element.ts 40% <100%> (-60%) ⬇️
components/test.ts 100% <100%> (ø) ⬆️
components/core/util/check.ts 30.55% <100%> (-61.12%) ⬇️
...mponents/input-number/nz-input-number.component.ts 98.26% <100%> (-0.58%) ⬇️
components/core/util/throttleByAnimationFrame.ts 14.28% <0%> (-80.96%) ⬇️
components/core/testing/event-objects.ts 14.81% <0%> (-77.78%) ⬇️
components/core/util/getMentions.ts 10% <0%> (-50%) ⬇️
... and 494 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd494b...d6d268c. Read the comment docs.

@wzhudev wzhudev reopened this Mar 12, 2019
@wzhudev wzhudev requested a review from vthinkxie March 12, 2019 16:05
@wzhudev wzhudev closed this Mar 13, 2019
@wzhudev wzhudev deleted the tsconfig-function-types-this branch March 13, 2019 11:53
@wzhudev
Copy link
Member Author

wzhudev commented Mar 13, 2019

Closed because codecov seemed abnormal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant