fix(module:table): fix table filter not change after click the checkbox #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit a04bd8e |
Codecov Report
@@ Coverage Diff @@
## master #3058 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 549 549
Lines 11490 11490
Branches 815 815
=======================================
Hits 11183 11183
Misses 197 197
Partials 110 110Continue to review full report at Codecov.
|
|
Hi @gongsiyi123 |
I add a single test :) |
vthinkxie
requested changes
Mar 11, 2019
| }).createComponent(NzTestDisableThComponent); | ||
| }).toThrow(); | ||
| }); | ||
| it('should filterChange be called after check the checkbox', () => { |
There was a problem hiding this comment.
这个测试用例在之前的代码也可以正常通过，不能用于保证该部分代码改动
3 tasks
vthinkxie
added a commit
that referenced
this pull request
Mar 11, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ox issue#3056
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3056
What is the new behavior?
fixed the bug of issue #3056 , now table filter works fine after click the checkbox. the only change is to add < (nzCheckedChange)="checkMultiple(filter)" > to the nz-checkbox of the filter dropdown. Because I
have followed the code and I found the nz-checkbox.nzCheckedChange method doesn't be called after user click the checkbox. In the current code, the checkMultiple(filter) method be called only when click the li item, so I add the nzCheckedChange to nz-checkbox.
在nz-th.component.html的46-50行，li上有(click)="checkMultiple(filter)，但里面的label(nz-checkbox)在nzCheckedChange时不会触发checkMultiple(filter)方法。所以用户点击checkbox不会触发filter变化，只有点击整个li时才会触发变化
Does this PR introduce a breaking change?
Other information