Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:steps): fix steps state change error under onpus strategy #3061

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix(module:steps): fix steps state change error under onpus strategy #3061

merged 1 commit into from
Mar 11, 2019

Conversation

CoderPoet
Copy link
Contributor

@CoderPoet CoderPoet commented Mar 11, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

when we use steps under onpush stategy , modify the nzCurrent can correct diplay step status.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 359f066

https://deploy-preview-3061--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3061 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         549      549           
  Lines       11490    11490           
  Branches      815      815           
=======================================
  Hits        11183    11183           
  Misses        197      197           
  Partials      110      110
Impacted Files Coverage Δ
components/steps/nz-steps.component.ts 100% <100%> (ø) ⬆️
components/steps/nz-step.component.ts 97.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d70be...359f066. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 97adb2c into NG-ZORRO:master Mar 11, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants