Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add remaining tsconfig #3083

Merged
merged 4 commits into from
Mar 13, 2019
Merged

build: add remaining tsconfig #3083

merged 4 commits into from
Mar 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3083 into master will decrease coverage by <.01%.
The diff coverage is 99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   97.32%   97.32%   -0.01%     
==========================================
  Files         550      550              
  Lines       11495    11510      +15     
  Branches      817      819       +2     
==========================================
+ Hits        11188    11202      +14     
  Misses        199      199              
- Partials      108      109       +1
Impacted Files Coverage Δ
components/core/overlay/overlay-position.ts 100% <ø> (ø) ⬆️
components/core/util/textarea-caret-position.ts 48.93% <ø> (ø) ⬆️
components/core/polyfill/request-animation.ts 21.73% <ø> (ø) ⬆️
components/tooltip/nz-tooltip.component.ts 92.18% <ø> (ø) ⬆️
components/tooltip/nz-tooltip.directive.ts 98.78% <ø> (ø) ⬆️
components/core/scroll/nz-scroll.service.ts 81.25% <ø> (ø) ⬆️
components/modal/nz-modal.component.ts 99.01% <100%> (ø) ⬆️
components/progress/nz-progress.component.ts 100% <100%> (ø) ⬆️
components/core/testing/type-in-element.ts 100% <100%> (ø) ⬆️
...omponents/date-picker/abstract-picker.component.ts 100% <100%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f039d...06d4155. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d6d268c

https://deploy-preview-3083--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Mar 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 06d4155

https://deploy-preview-3083--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 494e18f into NG-ZORRO:master Mar 13, 2019
@wzhudev wzhudev deleted the tsconfig branch March 13, 2019 12:29
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants