-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:form): support hide the label colon #3136
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 0c86287 |
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 97.48% 97.48% +<.01%
==========================================
Files 607 607
Lines 11870 11894 +24
Branches 867 867
==========================================
+ Hits 11571 11595 +24
Misses 190 190
Partials 109 109
Continue to review full report at Codecov.
|
Would be not better to name it as “nzShowColon” and set it to “true” as default? Its just a idea. |
@TheAifam5 thanks for your suggestion, but we want boolean attributes default value is https://www.w3.org/TR/html5/infrastructure.html#sec-boolean-attributes
|
52c1bfc
to
58ba05d
Compare
58ba05d
to
0c86287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Sync ant-design/ant-design#15276
Ref ant-design/ant-design#15585