Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:form): support hide the label colon #3136

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sync ant-design/ant-design#15276
Ref ant-design/ant-design#15585

@netlify
Copy link

netlify bot commented Mar 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0c86287

https://deploy-preview-3136--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #3136 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3136      +/-   ##
==========================================
+ Coverage   97.48%   97.48%   +<.01%     
==========================================
  Files         607      607              
  Lines       11870    11894      +24     
  Branches      867      867              
==========================================
+ Hits        11571    11595      +24     
  Misses        190      190              
  Partials      109      109
Impacted Files Coverage Δ
components/form/nz-form-label.component.ts 100% <100%> (ø) ⬆️
components/form/nz-form-item.component.ts 100% <100%> (ø) ⬆️
components/form/nz-form.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032d193...0c86287. Read the comment docs.

@TheAifam5
Copy link

Would be not better to name it as “nzShowColon” and set it to “true” as default?

Its just a idea.

@hsuanxyz
Copy link
Member Author

@TheAifam5 thanks for your suggestion, but we want boolean attributes default value is false.

https://www.w3.org/TR/html5/infrastructure.html#sec-boolean-attributes

A number of attributes are boolean attributes. The presence of a boolean attribute on an element represents the true value, and the absence of the attribute represents the false value.

@vthinkxie vthinkxie changed the title feat(module:form): support hide the lable colon feat(module:form): support hide the label colon Apr 17, 2019
@hsuanxyz hsuanxyz force-pushed the feat/form-colon branch 2 times, most recently from 52c1bfc to 58ba05d Compare April 18, 2019 08:46
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 663169f into NG-ZORRO:master Apr 19, 2019
@hsuanxyz hsuanxyz deleted the feat/form-colon branch April 22, 2019 02:39
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants