Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:core): add universal logger funcs and deprecation warnings #3538

Merged
merged 16 commits into from
Jun 18, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: modify the `LoggerServive` to only report warnings and errors in dev mode.

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vthinkxie vthinkxie mentioned this pull request Jun 5, 2019
12 tasks
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #3538 into master will increase coverage by 0.01%.
The diff coverage is 85.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   95.73%   95.74%   +0.01%     
==========================================
  Files         690      689       -1     
  Lines       13708    13705       -3     
  Branches     1824     1821       -3     
==========================================
- Hits        13123    13122       -1     
+ Misses        198      195       -3     
- Partials      387      388       +1
Impacted Files Coverage Δ
components/i18n/nz-i18n.module.ts 100% <ø> (ø) ⬆️
components/core/util/textarea-caret-position.ts 43.63% <ø> (+1.53%) ⬆️
components/tree/nz-tree.component.ts 98.66% <100%> (+0.07%) ⬆️
components/upload/nz-upload-btn.component.ts 96.44% <100%> (ø) ⬆️
components/tree/nz-tree-node.component.ts 94.75% <100%> (+0.02%) ⬆️
components/modal/nz-modal.module.ts 100% <100%> (ø) ⬆️
components/breadcrumb/nz-breadcrumb.component.ts 92.15% <100%> (ø) ⬆️
components/icon/nz-icon.service.ts 98.11% <100%> (-0.17%) ⬇️
components/core/tree/nz-tree-base-node.ts 90.9% <100%> (+0.28%) ⬆️
components/empty/nz-empty.service.ts 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5033083...7167cc2. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 5, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7167cc2

https://deploy-preview-3538--ng-zorro-master.netlify.com

@wzhudev wzhudev changed the title chore: add universal logger service chore: add universal logger funcs Jun 5, 2019
@wzhudev wzhudev changed the title chore: add universal logger funcs chore: add universal logger funcs and deprecation warnings Jun 5, 2019
tslint.json Outdated Show resolved Hide resolved
tslint.json Outdated Show resolved Hide resolved
@hsuanxyz hsuanxyz changed the title chore: add universal logger funcs and deprecation warnings feat(module:core): add universal logger funcs and deprecation warnings Jun 6, 2019
@vthinkxie vthinkxie merged commit b893520 into NG-ZORRO:master Jun 18, 2019
@wzhudev wzhudev deleted the logger-service branch June 18, 2019 07:07
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
NG-ZORRO#3538)

* chore: add universal logger service

* chore: rename to NzLoggerService to avoid conflication with users'

* chore: use funcs instead of service

* fix: fix record not working

* chore: show error all the time

* fix: unused

* fix: simply usage

* fix: remove namespace

* revert: tslint

* revert: lint

* fix: tree

* fix: self import

* fix: tests

* fix: jump over bad test

* fix: test

* fix: test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
NG-ZORRO#3538)

* chore: add universal logger service

* chore: rename to NzLoggerService to avoid conflication with users'

* chore: use funcs instead of service

* fix: fix record not working

* chore: show error all the time

* fix: unused

* fix: simply usage

* fix: remove namespace

* revert: tslint

* revert: lint

* fix: tree

* fix: self import

* fix: tests

* fix: jump over bad test

* fix: test

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants