-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:core): add universal logger funcs and deprecation warnings #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
+ Coverage 95.73% 95.74% +0.01%
==========================================
Files 690 689 -1
Lines 13708 13705 -3
Branches 1824 1821 -3
==========================================
- Hits 13123 13122 -1
+ Misses 198 195 -3
- Partials 387 388 +1
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 7167cc2 |
wzhudev
changed the title
chore: add universal logger service
chore: add universal logger funcs
Jun 5, 2019
wzhudev
changed the title
chore: add universal logger funcs
chore: add universal logger funcs and deprecation warnings
Jun 5, 2019
hsuanxyz
requested changes
Jun 6, 2019
hsuanxyz
changed the title
chore: add universal logger funcs and deprecation warnings
feat(module:core): add universal logger funcs and deprecation warnings
Jun 6, 2019
wenqi73
reviewed
Jun 6, 2019
vthinkxie
reviewed
Jun 18, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
NG-ZORRO#3538) * chore: add universal logger service * chore: rename to NzLoggerService to avoid conflication with users' * chore: use funcs instead of service * fix: fix record not working * chore: show error all the time * fix: unused * fix: simply usage * fix: remove namespace * revert: tslint * revert: lint * fix: tree * fix: self import * fix: tests * fix: jump over bad test * fix: test * fix: test
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
NG-ZORRO#3538) * chore: add universal logger service * chore: rename to NzLoggerService to avoid conflication with users' * chore: use funcs instead of service * fix: fix record not working * chore: show error all the time * fix: unused * fix: simply usage * fix: remove namespace * revert: tslint * revert: lint * fix: tree * fix: self import * fix: tests * fix: jump over bad test * fix: test * fix: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes / features)[ ] Docs have been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information