-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:carousel): support dot position #3575
Conversation
Deploy preview for ng-zorro-master ready! Built with commit b873607 |
54f0439
to
1098151
Compare
Codecov Report
@@ Coverage Diff @@
## master #3575 +/- ##
==========================================
+ Coverage 95.72% 95.73% +<.01%
==========================================
Files 690 690
Lines 13708 13727 +19
Branches 1824 1827 +3
==========================================
+ Hits 13122 13141 +19
Misses 198 198
Partials 388 388
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(module:carousel): support dot position * fix(module:carousel): fix content height in vertical mode * fix: typo
* feat(module:carousel): support dot position * fix(module:carousel): fix content height in vertical mode * fix: typo
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Dots can be placed on the top, left, bottom or right.
nzVertical
is deprecated and will be removed in 9.0.0.Does this PR introduce a breaking change?
Other information