-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nz-table: add nzIsPageIndexReset option #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlcheXie , thanks for your pr, please make sure your commit history clean and meet the guidelines here https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Your commit history https://github.com/NG-ZORRO/ng-zorro-antd/pull/359/commits
You can use squash to remove the unnecessary commit history.
299e4a4
to
2dba90f
Compare
Please forgive me for my bad habits since I had never opened pr before. |
2dba90f
to
34cd9d1
Compare
34cd9d1
to
e5a9913
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #348
What is the new behavior?
Does this PR introduce a breaking change?
Other information