Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): buttons cannot disable when confirm mode #3707

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jul 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3679

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 61d4384

https://deploy-preview-3707--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #3707 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3707   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         699      699           
  Lines       14490    14490           
  Branches     1913     1913           
=======================================
  Hits        13821    13821           
  Misses        243      243           
  Partials      426      426
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 95.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af314da...61d4384. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 3847250 into NG-ZORRO:master Jul 15, 2019
lppedd pushed a commit to lppedd/ng-zorro-antd that referenced this pull request Jul 15, 2019
…#3707)

* fix(module:modal): buttons cannot disable when confirm mode

close NG-ZORRO#3679

* fix: fix build
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…#3707)

* fix(module:modal): buttons cannot disable when confirm mode

close NG-ZORRO#3679

* fix: fix build
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…#3707)

* fix(module:modal): buttons cannot disable when confirm mode

close NG-ZORRO#3679

* fix: fix build
@hsuanxyz hsuanxyz deleted the fix/modal-disable branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants