fix(module:dropdown): restore escape and hide backdrop when disabled #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
+ Coverage 95.36% 95.36% +<.01%
==========================================
Files 723 723
Lines 14722 14724 +2
Branches 1937 1937
==========================================
+ Hits 14040 14042 +2
Misses 249 249
Partials 433 433
Continue to review full report at Codecov.
|
lppedd
force-pushed
the
dropdown-backdrop
branch
from
28c3e76
to
fb1513b
Compare
|
Deploy preview for ng-zorro-master ready! Built with commit e6fcea0 |
lppedd
force-pushed
the
dropdown-backdrop
branch
from
fb1513b
to
756bbf8
Compare
lppedd
force-pushed
the
dropdown-backdrop
branch
from
756bbf8
to
e6fcea0
Compare
vthinkxie
approved these changes
Jul 26, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After PR #3769, I noticed that to exit the dropdown, one must click on the backdrop DOM element.
Being with
nzBackdrop=falsethere was no such element, it was not possible to hide the visible dropdown.What is the new behavior?
When
nzBackdrop=false, the backdrop is present, butopacityis always set to0.Also, the
Escapefunctionality to hide the dropdown has been restored, as it was lost when the Component has been refactored to a Directive (cdk-connected-overlayis no more present).Does this PR introduce a breaking change?