Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support nzKeyboard property #3896

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for ng-zorro-master ready!

Built with commit af87fec

https://deploy-preview-3896--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #3896 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3896      +/-   ##
==========================================
+ Coverage   95.24%   95.24%   +<.01%     
==========================================
  Files         726      726              
  Lines       14672    14673       +1     
  Branches     1910     1910              
==========================================
+ Hits        13974    13976       +2     
  Misses        260      260              
+ Partials      438      437       -1
Impacted Files Coverage Δ
components/drawer/nz-drawer-ref.ts 100% <ø> (ø) ⬆️
components/drawer/nz-drawer.component.ts 97.09% <100%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cd286...af87fec. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wzhudev wzhudev merged commit 38062fb into NG-ZORRO:master Aug 9, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the feat/drawer-esc branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants