Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:tree): change the collapsed of the treeNode to ngIf #3947

Merged
merged 1 commit into from
Oct 14, 2019
Merged

perf(module:tree): change the collapsed of the treeNode to ngIf #3947

merged 1 commit into from
Oct 14, 2019

Conversation

qqabcv520
Copy link
Contributor

@qqabcv520 qqabcv520 commented Aug 8, 2019

Change the collapsed of the treeNode from display: none to *ngIf.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4182

Use display: none to collapse treeNode.

What is the new behavior?

Change the collapsed of the treeNode from display: none to *ngIf.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 8, 2019

Deploy preview for ng-zorro-master ready!

Built with commit de1b6e3

https://deploy-preview-3947--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz requested a review from simplejason August 8, 2019 02:04
@hsuanxyz hsuanxyz assigned simplejason and unassigned simplejason Aug 8, 2019
@simplejason simplejason requested a review from wenqi73 August 28, 2019 03:57
@wenqi73
Copy link
Member

wenqi73 commented Sep 9, 2019

测试有误,请修改一下。

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #3947 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3947      +/-   ##
==========================================
- Coverage   92.18%   92.17%   -0.01%     
==========================================
  Files         520      520              
  Lines       11011    11013       +2     
  Branches     1995     1995              
==========================================
+ Hits        10150    10151       +1     
- Misses        430      431       +1     
  Partials      431      431
Impacted Files Coverage Δ
components/tree/nz-tree-node.component.ts 88.83% <ø> (ø) ⬆️
components/core/animation/collapse.ts 100% <100%> (ø) ⬆️
components/core/tree/nz-tree-base-node.ts 88.57% <0%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2f5ce...de1b6e3. Read the comment docs.

@qqabcv520
Copy link
Contributor Author

测试有误,请修改一下。

因为实现折叠的方式变了,之前的测试代码要修改,之前 @simplejason 说修改一直没改

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run

git fetch upstream
git pull --rebase upstream master

when you have synced codes with master, check https://github.com/simplejason/ng-zorro-antd/commit/a63700d9f0da2741f1c15e304fa80b989a7ace4e to change your spec file.

@simplejason
Copy link
Member

run

git fetch upstream
git pull --rebase upstream master

when you have synced codes with master, check https://github.com/simplejason/ng-zorro-antd/commit/a63700d9f0da2741f1c15e304fa80b989a7ace4e to change your spec file.

we will merge it after testing passed

Change the collapsed of the treeNode from display: none to *ngIf.
@qqabcv520 qqabcv520 requested a review from simplejason October 14, 2019 09:55
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ORRO#3947)

Change the collapsed of the treeNode from display: none to *ngIf.
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ORRO#3947)

Change the collapsed of the treeNode from display: none to *ngIf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants