Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tsconfig for better vscode integration #3949

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: Improve coding experience with vscode by modifying .tsconfig files

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

vscode cannot handle multiple .tsconfig files in the same directory. See microsoft/TypeScript#8435 and microsoft/vscode#12463. This PR could improve developing experience for contributors who use vscode.

Typically in spec files:

屏幕快照 2019-08-08 下午3 35 14

@wzhudev wzhudev changed the title chore: update tsconfig for better IDE integration chore: update tsconfig for better vscode integration Aug 8, 2019
@netlify
Copy link

netlify bot commented Aug 8, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f5a0509

https://deploy-preview-3949--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #3949 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3949   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         777      777           
  Lines       14825    14825           
  Branches     1911     1911           
=======================================
  Hits        14127    14127           
  Misses        260      260           
  Partials      438      438

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045eef4...f5a0509. Read the comment docs.

@wzhudev wzhudev requested a review from wenqi73 August 8, 2019 07:50
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 583eb77 into NG-ZORRO:master Aug 9, 2019
@wzhudev wzhudev deleted the tsconfig-ide branch August 9, 2019 02:05
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants