-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:cascader): support falsy value expect for undefined and null #4119
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 4ccfc53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test case?
Codecov Report
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 506 506
Lines 10761 10761
Branches 1952 1952
=======================================
Hits 9935 9935
Misses 407 407
Partials 419 419
Continue to review full report at Codecov.
|
Will be covered in spec |
…ll (NG-ZORRO#4119) * fix(module:cascader): support falsy value expect for undefined and null * fix: tests close NG-ZORRO#4110
…ll (NG-ZORRO#4119) * fix(module:cascader): support falsy value expect for undefined and null * fix: tests close NG-ZORRO#4110
close #4110
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4110
What is the new behavior?
Value could be falsy value expect for
undefined
andnull
.Does this PR introduce a breaking change?
Other information