Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:spin): support global indicator #4221

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 26, 2019

close #2792

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2792

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@auto-assign auto-assign bot requested a review from wenqi73 September 26, 2019 03:57
@wzhudev wzhudev changed the title test: add test feat(module:spin): support global indicator Sep 26, 2019
@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 8b7185a

https://deploy-preview-4221--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit dc3c2ec

https://deploy-preview-4221--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #4221 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4221      +/-   ##
==========================================
+ Coverage   92.31%   92.32%   +<.01%     
==========================================
  Files         519      519              
  Lines       10963    10968       +5     
  Branches     1984     1984              
==========================================
+ Hits        10121    10126       +5     
- Misses        419      420       +1     
+ Partials      423      422       -1
Impacted Files Coverage Δ
components/core/config/config.ts 100% <ø> (ø) ⬆️
components/spin/nz-spin.component.ts 100% <100%> (ø) ⬆️
components/typography/nz-typography.component.ts 97.93% <0%> (-1.04%) ⬇️
components/time-picker/time-holder.ts 97.36% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704c34f...dc3c2ec. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit a7ecb8b into NG-ZORRO:master Oct 14, 2019
@wzhudev wzhudev deleted the spin-indicator-global branch October 20, 2019 03:12
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible? to custom spin indicator in all view with one templateRef
3 participants