Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make the better type of TS #4246

Merged
merged 3 commits into from
Oct 14, 2019
Merged

docs: make the better type of TS #4246

merged 3 commits into from
Oct 14, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@auto-assign auto-assign bot requested a review from wenqi73 September 29, 2019 11:33
@codecov
Copy link

codecov bot commented Sep 29, 2019 •
edited
Loading

Codecov Report

Merging #4246 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4246      +/-   ##
==========================================
+ Coverage   92.17%   92.18%   +0.01%     
==========================================
  Files         520      520              
  Lines       11000    11005       +5     
  Branches     1993     1995       +2     
==========================================
+ Hits        10139    10145       +6     
+ Misses        430      429       -1     
  Partials      431      431
Impacted Files Coverage Δ
components/comment/demo/editor.ts 100% <ø> (ø) ⬆️
components/page-header/demo/basic.ts 50% <ø> (ø) ⬆️
components/slider/nz-slider-definitions.ts 100% <ø> (ø) ⬆️
components/resizable/demo/lock-aspect-ratio.ts 100% <100%> (ø) ⬆️
components/resizable/demo/preview.ts 100% <100%> (ø) ⬆️
components/slider/nz-slider.component.ts 91.87% <100%> (ø) ⬆️
components/resizable/demo/customize.ts 100% <100%> (ø) ⬆️
components/resizable/demo/basic.ts 100% <100%> (ø) ⬆️
components/resizable/demo/grid.ts 100% <100%> (ø) ⬆️
...auto-complete/nz-autocomplete-trigger.directive.ts 96.03% <0%> (+0.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f947e...f1c334d. Read the comment docs.

@netlify
Copy link

netlify bot commented Sep 29, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit f1c334d

https://deploy-preview-4246--ng-zorro-master.netlify.com

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
vthinkxie
vthinkxie reviewed Oct 12, 2019
View reviewed changes
components/cascader/demo/change-on-function.ts Outdated
@@ -69,15 +69,15 @@ const options = [
]
})
export class NzDemoCascaderChangeOnFunctionComponent {
nzOptions = options;
values: any[] | null = null;
nzOptions: CascaderOption[] = options;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NzCascaderOption

vthinkxie
vthinkxie requested changes Oct 12, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CascaderOption - > NzCascaderOption

@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
vthinkxie
vthinkxie approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit f3a74f7 into NG-ZORRO:master Oct 14, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
docs: make the better type of TS (NG-ZORRO#4246)
602601e 
* docs: make the better type of ts

* docs: fix demo filename

* docs: update cascader demos
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz @vthinkxie
docs: make the better type of TS (NG-ZORRO#4246)
7e8f6ad 
* docs: make the better type of ts

* docs: fix demo filename

* docs: update cascader demos
@hsuanxyz hsuanxyz deleted the fix/demo branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

@wenqi73 wenqi73 Awaiting requested review from wenqi73 wenqi73 is a code owner

Assignees

@cipchk cipchk

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuanxyz @vthinkxie @cipchk