Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:checkbox): update usage documents #4310

Closed
wants to merge 1 commit into from

Conversation

BenTuTu
Copy link

@BenTuTu BenTuTu commented Oct 17, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vthinkxie
Copy link
Member

vthinkxie commented Oct 17, 2019

Thanks for your PR.
nzChecked is the same as ngModel, ngModel is recommended, nzChecked will be deprecated in the future.

@netlify
Copy link

netlify bot commented Oct 17, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 758e6c1

https://deploy-preview-4310--ng-zorro-master.netlify.com

@vthinkxie vthinkxie closed this Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4310 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4310      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +<.01%     
==========================================
  Files         520      520              
  Lines       11016    11016              
  Branches     1997     1997              
==========================================
+ Hits        10152    10153       +1     
  Misses        431      431              
+ Partials      433      432       -1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f203afd...758e6c1. Read the comment docs.

@BenTuTu
Copy link
Author

BenTuTu commented Oct 18, 2019

Thanks for your PR.
nzChecked is the same as ngModel, ngModel is recommended, nzChecked will be deprecated in the future.

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants