Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): fix the HTML structure of the drawer header #4311

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Oct 17, 2019

close #4304

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4304

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 17, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6f1029d

https://deploy-preview-4311--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4311 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +<.01%     
==========================================
  Files         520      520              
  Lines       11016    11016              
  Branches     1997     1997              
==========================================
+ Hits        10152    10153       +1     
  Misses        431      431              
+ Partials      433      432       -1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f203afd...6f1029d. Read the comment docs.

@vthinkxie vthinkxie merged commit 5cdd5db into NG-ZORRO:master Oct 23, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ORRO#4311)

* fix(module:drawer): fix the HTML structure of the drawer header

close NG-ZORRO#4304

* fix(module:drawer): fix the template conditions

* test(module:drawer): fix test

* fix(module:drawer): fix the template conditions
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ORRO#4311)

* fix(module:drawer): fix the HTML structure of the drawer header

close NG-ZORRO#4304

* fix(module:drawer): fix the template conditions

* test(module:drawer): fix test

* fix(module:drawer): fix the template conditions
@hsuanxyz hsuanxyz deleted the fix/drawer-close-button branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-drawer: close button is visible though nzVisible is false
3 participants