Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): overlay panel flicker when position changes #4315

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #4315 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4315      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +0.01%     
==========================================
  Files         520      520              
  Lines       11016    11020       +4     
  Branches     1997     1999       +2     
==========================================
+ Hits        10152    10157       +5     
  Misses        431      431              
+ Partials      433      432       -1
Impacted Files Coverage Δ
...te-picker/lib/calendar/calendar-input.component.ts 100% <100%> (ø) ⬆️
components/date-picker/picker.component.ts 97.36% <100%> (+0.14%) ⬆️
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f203afd...c37db90. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit c37db90

https://deploy-preview-4315--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit 931fd48 into NG-ZORRO:master Nov 8, 2019
@wenqi73 wenqi73 deleted the overlay-position branch April 2, 2020 10:09
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants