Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): add v9 migration rules for dropdown #4466

Merged

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 22, 2019

This preview will be available after the checks is complete.

@netlify
Copy link

netlify bot commented Nov 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 26d214d

https://deploy-preview-4466--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #4466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4466   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         517      517           
  Lines       10999    10999           
  Branches     2006     2006           
=======================================
  Hits        10115    10115           
  Misses        453      453           
  Partials      431      431

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82e8a6...26d214d. Read the comment docs.

@simplejason simplejason self-requested a review November 22, 2019 11:09
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit aebad87 into NG-ZORRO:master Nov 22, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the schematics/migration-v9-dropdown branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants