Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tree-select): support nzDropdownClassName property #4552

Merged

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4508

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 11, 2019

This preview will be available after the TravisCI is passed.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #4552 into master will decrease coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4552      +/-   ##
==========================================
- Coverage   93.22%   93.21%   -0.02%     
==========================================
  Files         506      506              
  Lines       12757    12764       +7     
  Branches     1962     1965       +3     
==========================================
+ Hits        11893    11898       +5     
- Misses        452      453       +1     
- Partials      412      413       +1
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 98.22% <87.5%> (-0.41%) ⬇️
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50e9c2...5190d12. Read the comment docs.

@wenqi73 wenqi73 requested a review from wzhudev February 3, 2020 08:20
@wenqi73 wenqi73 assigned wzhudev and unassigned vthinkxie Feb 3, 2020
wzhudev
wzhudev previously approved these changes Feb 3, 2020
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz force-pushed the feat/tree-select-dropdown-class-name branch from a9a1e11 to 5190d12 Compare February 11, 2020 10:16
@vthinkxie vthinkxie merged commit df8c125 into NG-ZORRO:master Feb 11, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 11, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ZORRO#4552)

* feat(module:tree-select): support `nzDropdownClassName` property

close NG-ZORRO#4508

* docs(module:tree-select): update API
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#4552)

* feat(module:tree-select): support `nzDropdownClassName` property

close NG-ZORRO#4508

* docs(module:tree-select): update API
@hsuanxyz hsuanxyz deleted the feat/tree-select-dropdown-class-name branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants