Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:tree, tree-select): remove deprecated API #4601

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist
Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGE:

  • tree
  • Removed [nzDefaultExpandAll] use [nzExpandAll] instead.
  • Removed [nzDefaultExpandedKeys] use [nzExpandedKeys] instead.
  • Removed [nzDefaultSelectedKeys] use [nzSelectedKeys] instead.
  • Removed [nzDefaultCheckedKeys] use [nzCheckedKeys] instead.
  • Removed (nzOnSearchNode) use (nzSearchValueChange) instead.
  • tree-select
  • Removed [nzDefaultExpandedKeys] use [nzExpandedKeys] instead.

BREAKING CHANGE:

* tree
 - Removed `[nzDefaultExpandAll]` use `[nzExpandAll]` instead.
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
 - Removed `[nzDefaultSelectedKeys]` use `[nzSelectedKeys]` instead.
 - Removed `[nzDefaultCheckedKeys]` use `[nzCheckedKeys]` instead.
 - Removed `(nzOnSearchNode)` use `(nzSearchValueChange)` instead.

* tree-select
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@44da730). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4601   +/-   ##
=========================================
  Coverage          ?   93.23%           
=========================================
  Files             ?      519           
  Lines             ?    12792           
  Branches          ?     2012           
=========================================
  Hits              ?    11926           
  Misses            ?      449           
  Partials          ?      417
Impacted Files Coverage Δ
components/tree/nz-tree.component.ts 98.46% <ø> (ø)
components/tree-select/nz-tree-select.component.ts 95.87% <ø> (ø)
components/tree/nz-tree-node.component.ts 89.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44da730...5a8fec7. Read the comment docs.

@hsuanxyz hsuanxyz added the 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes label Dec 27, 2019
@hsuanxyz hsuanxyz added this to the 9.0.0 milestone Dec 27, 2019
@wzhudev wzhudev assigned simplejason and hsuanxyz and unassigned wzhudev Dec 30, 2019
@wenqi73 wenqi73 merged commit 1ec18e4 into NG-ZORRO:master Jan 8, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:tree, tree-select): remove deprecated API


BREAKING CHANGE:

* tree
 - Removed `[nzDefaultExpandAll]` use `[nzExpandAll]` instead.
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
 - Removed `[nzDefaultSelectedKeys]` use `[nzSelectedKeys]` instead.
 - Removed `[nzDefaultCheckedKeys]` use `[nzCheckedKeys]` instead.
 - Removed `(nzOnSearchNode)` use `(nzSearchValueChange)` instead.

* tree-select
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:tree, tree-select): remove deprecated API


BREAKING CHANGE:

* tree
 - Removed `[nzDefaultExpandAll]` use `[nzExpandAll]` instead.
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
 - Removed `[nzDefaultSelectedKeys]` use `[nzSelectedKeys]` instead.
 - Removed `[nzDefaultCheckedKeys]` use `[nzCheckedKeys]` instead.
 - Removed `(nzOnSearchNode)` use `(nzSearchValueChange)` instead.

* tree-select
 - Removed `[nzDefaultExpandedKeys]` use `[nzExpandedKeys]` instead.
@hsuanxyz hsuanxyz deleted the chore/remove-tree-api branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: merge-ready PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants