Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:transfer): fix transfer nzTargetKeys property #4670

Merged
merged 7 commits into from
Mar 15, 2020
Merged

fix(module:transfer): fix transfer nzTargetKeys property #4670

merged 7 commits into from
Mar 15, 2020

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jan 11, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4641 #4360 #4210

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 11, 2020

This preview will be available after the TravisCI is passed.

@codecov
Copy link

codecov bot commented Jan 11, 2020 •
edited
Loading

Codecov Report

Merging #4670 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4670      +/-   ##
=========================================
- Coverage   93.21%   93.2%   -0.02%     
=========================================
  Files         505     505              
  Lines       12742   12752      +10     
  Branches     1955    1957       +2     
=========================================
+ Hits        11877   11885       +8     
- Misses        455     456       +1     
- Partials      410     411       +1
Impacted Files Coverage Δ
components/transfer/nz-transfer.component.ts 98.3% <100%> (+0.15%) ⬆️
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️
components/time-picker/time-holder.ts 97.31% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0dedcb...6c36861. Read the comment docs.

@Ricbet Ricbet force-pushed the fix-transfer-nz-target-keys-property branch from 3b61e75 to 20b4c5e Compare January 14, 2020 06:07
@wenqi73 wenqi73 requested a review from cipchk February 3, 2020 08:28
@wenqi73 wenqi73 assigned cipchk and unassigned hsuanxyz Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@Ricbet Ricbet force-pushed the fix-transfer-nz-target-keys-property branch from 20b4c5e to 26678c5 Compare February 18, 2020 06:25
@weekly-digest weekly-digest bot mentioned this pull request Feb 23, 2020
Closed
@weekly-digest weekly-digest bot mentioned this pull request Mar 1, 2020
Closed
@vthinkxie vthinkxie merged commit 31089a1 into NG-ZORRO:master Mar 15, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 15, 2020
@weekly-digest weekly-digest bot mentioned this pull request Mar 15, 2020
Closed
@Ricbet Ricbet linked an issue Apr 3, 2020 that may be closed by this pull request
Transfer穿梭框 #4811
Closed
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:transfer): fix transfer nzTargetKeys property (NG-ZORRO#4670)
a98c1c3 
* fix(module:transfer): fix transfer nzTargetKeys property

* fix(module:transfer): includes to indexOf
close NG-ZORRO#4641 close NG-ZORRO#4360 close NG-ZORRO#4210
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@Ricbet
fix(module:transfer): fix transfer nzTargetKeys property (NG-ZORRO#4670)
3162d97 
* fix(module:transfer): fix transfer nzTargetKeys property

* fix(module:transfer): includes to indexOf
close NG-ZORRO#4641 close NG-ZORRO#4360 close NG-ZORRO#4210
@hsuanxyz hsuanxyz mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipchk cipchk Awaiting requested review from cipchk

Assignees

@cipchk cipchk

Labels
Component: Transfer PR: merged PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer穿梭框
4 participants
@Ricbet @vthinkxie @cipchk @hsuanxyz