Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:icon): support import icon in submodules #4673

Closed
wants to merge 2 commits into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 11, 2020

close #4668

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 11, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #4673 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4673      +/-   ##
=========================================
- Coverage   93.25%   93.2%   -0.05%     
=========================================
  Files         505     517      +12     
  Lines       12734   12824      +90     
  Branches     1957    2020      +63     
=========================================
+ Hits        11875   11953      +78     
- Misses        447     455       +8     
- Partials      412     416       +4
Impacted Files Coverage Δ
components/icon/nz-icon.directive.ts 96.61% <100%> (+0.11%) ⬆️
components/icon/nz-icon.service.ts 98.43% <100%> (+0.28%) ⬆️
components/icon/nz-icon.module.ts 100% <100%> (ø) ⬆️
components/core/testing/componet-bed.ts 81.81% <0%> (-9.1%) ⬇️
components/core/testing/event-objects.ts 89.28% <0%> (-4.27%) ⬇️
...ore/transition-patch/transition-patch.directive.ts 89.65% <0%> (-3.68%) ⬇️
components/tabs/nz-tabset.component.ts 93.42% <0%> (-1.32%) ⬇️
components/core/util/convert.ts 84.61% <0%> (-1.1%) ⬇️
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️
components/date-picker/lib/util.ts 97.05% <0%> (-0.24%) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048902e...20d6ce5. Read the comment docs.

@wzhudev wzhudev changed the title Icon multi inject feat(module:icon): support import icon in submodules Jan 11, 2020
@wzhudev
Copy link
Member Author

wzhudev commented Jan 11, 2020

得,codecov 又歇逼了

components/icon/doc/index.zh-CN.md Outdated Show resolved Hide resolved
components/icon/doc/index.en-US.md Outdated Show resolved Hide resolved
Wendell Hu added 2 commits February 13, 2020 09:16
feat(module:icon): support import icon in submodules

fix: fix patch

feat: rename API

docs: fix doc

fix: remove redundant code
@wzhudev
Copy link
Member Author

wzhudev commented Feb 13, 2020

I will move this feature into #4711. Closing now.

@wzhudev wzhudev closed this Feb 13, 2020
@wzhudev wzhudev deleted the icon-multi-inject branch February 13, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NZ_ICONS support multiple providers
3 participants