Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:timeline): fix reverse bug #4690

Merged
merged 5 commits into from
Feb 28, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 15, 2020

close #4509

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #4690 into master will increase coverage by 0.01%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4690      +/-   ##
==========================================
+ Coverage   93.18%   93.19%   +0.01%     
==========================================
  Files         501      501              
  Lines       12750    12734      -16     
  Branches     1957     1955       -2     
==========================================
- Hits        11881    11868      -13     
  Misses        457      457              
+ Partials      412      409       -3
Impacted Files Coverage Δ
components/timeline/timeline.module.ts 100% <ø> (ø)
components/core/util/dom.ts 76.92% <ø> (-4.03%) ⬇️
components/timeline/timeline-item.component.ts 100% <100%> (ø)
components/timeline/timeline.component.ts 97.5% <97.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5016e4...ae4fc67. Read the comment docs.

@hsuanxyz
Copy link
Member

@wendellhu95 Rebase 一下

@wzhudev
Copy link
Member Author

wzhudev commented Feb 19, 2020

ping @hsuanxyz

@hsuanxyz hsuanxyz merged commit 09bf8f4 into NG-ZORRO:master Feb 28, 2020
@wzhudev wzhudev deleted the timeline-rebase branch February 28, 2020 09:50
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:timeline): fix reverse bug

* fix: fix test

* chore: cleanup code

* fix: some consts

* test: refactor test

close NG-ZORRO#4509
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:timeline): fix reverse bug

* fix: fix test

* chore: cleanup code

* fix: some consts

* test: refactor test

close NG-ZORRO#4509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline with nzPending and nzReverse borken if initiated with nzReverse=true
3 participants