Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:tooltip,popover,popconfirm): refactor #4721

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4721 into master will increase coverage by 0.02%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4721      +/-   ##
==========================================
+ Coverage   93.22%   93.25%   +0.02%     
==========================================
  Files         506      503       -3     
  Lines       12757    12756       -1     
  Branches     1962     1960       -2     
==========================================
+ Hits        11893    11895       +2     
+ Misses        452      450       -2     
+ Partials      412      411       -1
Impacted Files Coverage Δ
components/popover/popover.module.ts 100% <ø> (ø)
components/popconfirm/popconfirm.module.ts 100% <ø> (ø)
components/tooltip/tooltip.module.ts 100% <ø> (ø)
components/tooltip/tooltip.ts 100% <100%> (ø)
components/popconfirm/popconfirm.ts 100% <100%> (ø)
components/tooltip/base.ts 94.66% <93.05%> (ø)
components/popover/popover.ts 93.75% <93.75%> (ø)
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️
components/tree-select/nz-tree-select.component.ts 98.22% <0%> (-0.41%) ⬇️
components/radio/nz-radio-button.component.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50e9c2...0a96948. Read the comment docs.

chore: refactor

chore: refactor

chore: merge redundant files

chore: remove redundant files

fix: path

fix: remove unused method

fix: remove useless ng-content

fix: constructor
@hsuanxyz hsuanxyz merged commit d5016e4 into NG-ZORRO:master Feb 19, 2020
@wzhudev wzhudev deleted the tooltip-9.0 branch February 25, 2020 10:45
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:tooltip,popover,popconfirm): refactor

chore: refactor

chore: refactor

chore: merge redundant files

chore: remove redundant files

fix: path

fix: remove unused method

fix: remove useless ng-content

fix: constructor

* feat(module:tooltip): close when title is null
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:tooltip,popover,popconfirm): refactor

chore: refactor

chore: refactor

chore: merge redundant files

chore: remove redundant files

fix: path

fix: remove unused method

fix: remove useless ng-content

fix: constructor

* feat(module:tooltip): close when title is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants