Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:result): refactor #4724

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 25, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #4724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4724   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         501      501           
  Lines       12750    12750           
  Branches     1957     1957           
=======================================
  Hits        11881    11881           
  Misses        457      457           
  Partials      412      412
Impacted Files Coverage Δ
components/result/result.module.ts 100% <ø> (ø)
components/result/result.component.ts 91.3% <ø> (ø)
components/result/result-cells.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5016e4...d3c2f57. Read the comment docs.

@hsuanxyz
Copy link
Member

@wendellhu95 Rebase 一下

@wzhudev
Copy link
Member Author

wzhudev commented Feb 19, 2020

ping @hsuanxyz

@hsuanxyz hsuanxyz merged commit 6534fd3 into NG-ZORRO:master Feb 25, 2020
@wzhudev wzhudev deleted the result-9.0 branch February 25, 2020 10:44
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants