Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:empty): refactor #4726

Merged
merged 4 commits into from
Feb 12, 2020
Merged

chore(module:empty): refactor #4726

merged 4 commits into from
Feb 12, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 25, 2020

feat(module:empty): add no description feature

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #4726 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
+ Coverage   93.24%   93.26%   +0.01%     
==========================================
  Files         507      505       -2     
  Lines       12748    12734      -14     
  Branches     1958     1957       -1     
==========================================
- Hits        11887    11876      -11     
+ Misses        450      447       -3     
  Partials      411      411
Impacted Files Coverage Δ
components/empty/empty.module.ts 100% <ø> (ø)
components/empty/partial/default.ts 100% <100%> (ø)
components/empty/config.ts 100% <100%> (ø)
components/empty/empty.component.ts 100% <100%> (ø)
components/empty/embed-empty.component.ts 96.07% <100%> (ø)
components/core/testing/componet-bed.ts 90.9% <100%> (ø) ⬆️
components/empty/partial/simple.ts 100% <100%> (ø)
components/ng-zorro-antd.module.ts
components/version/version.ts
components/upload/nz-upload.module.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2a80e...ca5a9d4. Read the comment docs.

feat(module:empty): add no description feature

refactor(module:empty): remove empty service

fix(module:empty): fix spec

fix: fix spec import path
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 048902e into NG-ZORRO:master Feb 12, 2020
@wzhudev wzhudev deleted the empty-9.0 branch February 13, 2020 00:58
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:empty): refactor

feat(module:empty): add no description feature

refactor(module:empty): remove empty service

fix(module:empty): fix spec

fix: fix spec import path

* fix: fix empty content detection is triggered too late

* test: skip falsy value test

* chore: remove redundant type check
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:empty): refactor

feat(module:empty): add no description feature

refactor(module:empty): remove empty service

fix(module:empty): fix spec

fix: fix spec import path

* fix: fix empty content detection is triggered too late

* test: skip falsy value test

* chore: remove redundant type check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants