-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(module:empty): refactor #4726
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4726 +/- ##
==========================================
+ Coverage 93.24% 93.26% +0.01%
==========================================
Files 507 505 -2
Lines 12748 12734 -14
Branches 1958 1957 -1
==========================================
- Hits 11887 11876 -11
+ Misses 450 447 -3
Partials 411 411
Continue to review full report at Codecov.
|
feat(module:empty): add no description feature refactor(module:empty): remove empty service fix(module:empty): fix spec fix: fix spec import path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* chore(module:empty): refactor feat(module:empty): add no description feature refactor(module:empty): remove empty service fix(module:empty): fix spec fix: fix spec import path * fix: fix empty content detection is triggered too late * test: skip falsy value test * chore: remove redundant type check
* chore(module:empty): refactor feat(module:empty): add no description feature refactor(module:empty): remove empty service fix(module:empty): fix spec fix: fix spec import path * fix: fix empty content detection is triggered too late * test: skip falsy value test * chore: remove redundant type check
feat(module:empty): add no description feature
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information