Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:slider): refactor #4730

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 26, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #4730 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4730      +/-   ##
==========================================
- Coverage   93.18%   93.13%   -0.05%     
==========================================
  Files         501      500       -1     
  Lines       12750    12764      +14     
  Branches     1957     1963       +6     
==========================================
+ Hits        11881    11888       +7     
- Misses        457      461       +4     
- Partials      412      415       +3     
Impacted Files Coverage Δ
components/core/util/array.ts 88.23% <0.00%> (-11.77%) ⬇️
components/cascader/nz-cascader.service.ts
...mponents/carousel/nz-carousel-content.directive.ts
components/cascader/nz-cascader-li.component.ts
...mponents/descriptions/nz-descriptions.component.ts
...nts/descriptions/nz-descriptions-item.component.ts
components/carousel/nz-carousel.component.ts
components/cascader/nz-cascader.component.ts
components/carousel/nz-carousel-definitions.ts
components/cascader/nz-cascader-definitions.ts
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5016e4...b9bf7ed. Read the comment docs.

@wzhudev
Copy link
Member Author

wzhudev commented Jan 28, 2020

Angular bug somewhere?

@hsuanxyz
Copy link
Member

@wendellhu95 Rebase 一下

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749

chore(module:slider): refactor slider

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749
@vthinkxie vthinkxie merged commit 171ae2a into NG-ZORRO:master Mar 15, 2020
@wzhudev wzhudev deleted the slider-9.0 branch March 15, 2020 09:39
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:slider): refactor slider

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749

chore(module:slider): refactor slider

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749

* fix: fix no step situation
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:slider): refactor slider

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749

chore(module:slider): refactor slider

fix: test

fix: remove redundant code

feat(module:slider): support change value through keyboard event

test: add test

chore: hide internal implementation

fix: fix import path

fix: fix import path

fix(module:slider): fix property type

close NG-ZORRO#4749

* fix: fix no step situation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants