Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Correct Grammar from "This tooltip have icon" to "This Tooltip has an Icon" #4784

Closed
wants to merge 1 commit into from

Conversation

prahaladbelavadi
Copy link
Contributor

Change tooltip content text from "This Tooltip Have Icon" to "This Tooltip has an Icon"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[*] Documentation content changes

What is the current behavior?

The current helper text on the Tooltip section displayed: "This Tooltip Have Icon".
This is grammatically incorrect.
A possible helper text that signifies same intent would be "This Tooltip has an Icon".

Issue Number: N/A

What is the new behavior?

Tooltip helper text has beec changed to "This Tooltip has an Icon".

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #4784 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4784      +/-   ##
=========================================
- Coverage   93.21%   93.2%   -0.01%     
=========================================
  Files         505     505              
  Lines       12742   12742              
  Branches     1955    1955              
=========================================
- Hits        11877   11876       -1     
  Misses        455     455              
- Partials      410     411       +1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.31% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760512a...ba9e8e9. Read the comment docs.

@prahaladbelavadi prahaladbelavadi changed the title Docs: Correct Grammar Docs: Correct Grammar from "This tooltip have icon" to "This Tooltip has an Icon" Feb 17, 2020
@wzhudev
Copy link
Member

wzhudev commented Feb 28, 2020

Please change the tittle of the commit message. Check our committing guideline.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit title.

@vthinkxie
Copy link
Member

This Pull Request is going to be closed since no update for a long time, feel free to open a new PR if needed.

@vthinkxie vthinkxie closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants