Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:pagination): add auto resize #4863

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 10, 2020

Upstream ant-design/ant-design#21959
Pending #4856

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 10, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #4863 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4863   +/-   ##
=======================================
  Coverage   91.53%   91.54%           
=======================================
  Files         536      536           
  Lines       13717    13726    +9     
  Branches     2042     2045    +3     
=======================================
+ Hits        12556    12565    +9     
  Misses        696      696           
  Partials      465      465           
Impacted Files Coverage Δ
components/pagination/pagination.component.ts 98.55% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8f268...49d1ee9. Read the comment docs.

@vthinkxie vthinkxie changed the title feat(module:pagination): add auto resize feat(module:carousel): add auto resize Mar 15, 2020
@wzhudev wzhudev changed the title feat(module:carousel): add auto resize feat(module:pagination): add auto resize Mar 15, 2020
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 1bb01b5 into NG-ZORRO:master Mar 24, 2020
@wzhudev wzhudev deleted the feat-pagination-resize branch March 24, 2020 12:50
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants