Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:date-picker): click date cell not work when changing month or year #4876

Merged
merged 2 commits into from
Apr 2, 2020
Merged

fix(module:date-picker): click date cell not work when changing month or year #4876

merged 2 commits into from
Apr 2, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 12, 2020 •
edited
Loading

Fixes #3499

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 12, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #4876 into master will decrease coverage by 0.08%.
The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4876      +/-   ##
==========================================
- Coverage   91.54%   91.45%   -0.09%     
==========================================
  Files         535      535              
  Lines       13712    13708       -4     
  Branches     2050     2040      -10     
==========================================
- Hits        12552    12537      -15     
- Misses        693      706      +13     
+ Partials      467      465       -2
Impacted Files Coverage Δ
...omponents/date-picker/calendar-footer.component.ts 95.83% <ø> (-0.17%) ⬇️
components/date-picker/lib/abstract-table.ts 89.28% <ø> (-0.72%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 90.21% <88.37%> (-1.67%) ⬇️
components/date-picker/date-picker.component.ts 96.47% <100.00%> (+0.07%) ⬆️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
components/date-picker/picker.component.ts 96.00% <100.00%> (+1.88%) ⬆️
components/date-picker/util.ts 97.50% <100.00%> (+0.13%) ⬆️
components/table/src/table-data.service.ts 78.12% <0.00%> (-10.97%) ⬇️
components/table/src/addon/filter.component.ts 58.46% <0.00%> (-4.70%) ⬇️
components/table/src/table/thead.component.ts 86.56% <0.00%> (-1.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b45a22...52aa224. Read the comment docs.

@wenqi73 wenqi73 force-pushed the input-disabled branch 3 times, most recently from 79ac491 to b89fe90 Compare March 14, 2020 08:32
@wenqi73 wenqi73 changed the title WIP: fix(module:date-picker): keydown Enter to change value in range picker fix(module:date-picker): keydown Enter to change value in range picker Mar 14, 2020
@wenqi73
Copy link
Member Author

wenqi73 commented Mar 14, 2020

Merge after #4833.

@wenqi73 wenqi73 requested a review from hsuanxyz March 14, 2020 08:44
@wenqi73 wenqi73 changed the title fix(module:date-picker): keydown Enter to change value in range picker WIP: fix(module:date-picker): keydown Enter to change value in range picker Mar 15, 2020
@weekly-digest weekly-digest bot mentioned this pull request Mar 15, 2020
Closed
@wenqi73 wenqi73 force-pushed the input-disabled branch 3 times, most recently from 0ce3554 to cad5f2c Compare March 19, 2020 14:06
@wenqi73 wenqi73 changed the title WIP: fix(module:date-picker): keydown Enter to change value in range picker fix(module:date-picker): click date not work when changing month or year Mar 20, 2020
@wenqi73 wenqi73 changed the title fix(module:date-picker): click date not work when changing month or year fix(module:date-picker): click date cell not work when changing month or year Mar 20, 2020
@hsuanxyz hsuanxyz merged commit 3aebe7c into NG-ZORRO:master Apr 2, 2020
@wenqi73 wenqi73 deleted the input-disabled branch April 2, 2020 06:22
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@wenqi73 @Ricbet
fix(module:date-picker): click date cell not work when changing month…
6e0b8de 
… or year (NG-ZORRO#4876)

* fix(module:date-picker): click date not work when changing month

Fixes NG-ZORRO#3499
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
Closed
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@wenqi73
fix(module:date-picker): click date cell not work when changing month…
43337f2 
… or year (NG-ZORRO#4876)

* fix(module:date-picker): click date not work when changing month

Fixes NG-ZORRO#3499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsuanxyz hsuanxyz hsuanxyz approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

date-picker: disabled date will be saved
2 participants
@wenqi73 @hsuanxyz