Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add optional chaining and nullish coalescing #4946

Merged
merged 3 commits into from
Apr 7, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 27, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #4946 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4946      +/-   ##
==========================================
- Coverage   91.55%   91.53%   -0.02%     
==========================================
  Files         535      535              
  Lines       13686    13685       -1     
  Branches     2043     2042       -1     
==========================================
- Hits        12530    12527       -3     
- Misses        693      694       +1     
- Partials      463      464       +1     
Impacted Files Coverage Δ
components/core/config/config.service.ts 100.00% <100.00%> (ø)
components/core/time/candy-date.ts 89.51% <100.00%> (ø)
components/slider/handle.component.ts 96.15% <100.00%> (ø)
...ponents/time-picker/time-picker-panel.component.ts 93.58% <100.00%> (-0.03%) ⬇️
components/typography/text-edit.component.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ecdb9...2f05e7f. Read the comment docs.

@wenqi73 wenqi73 force-pushed the optional-chaining branch from ab0b5f7 to 3f026dd Compare March 27, 2020 05:36
@wenqi73 wenqi73 force-pushed the optional-chaining branch from 3f026dd to 2f05e7f Compare March 27, 2020 05:39
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@vthinkxie vthinkxie merged commit 33c0194 into NG-ZORRO:master Apr 7, 2020
@wenqi73 wenqi73 deleted the optional-chaining branch April 7, 2020 11:34
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:tooltip,etc): support custom origin (NG-ZORRO#4849)

* chore: sync ant-design v4.1.1 (NG-ZORRO#4987)

Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>

* feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces (NG-ZORRO#4984)

* fix(module:badge): allow `nzTitle` set to null (NG-ZORRO#4965)

close NG-ZORRO#4776

* chore: add optional chaining and nullish coalescing (NG-ZORRO#4946)

* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests

* feat(module:space): add new component (NG-ZORRO#4928)

close NG-ZORRO#4913

* feat: support compact theme (NG-ZORRO#4972)

Co-authored-by: Wendell <wendellhu95@gmail.com>
Co-authored-by: ng-zorro-bot <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: Wenqi <1264578441@qq.com>
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants