Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:autocomplete): support values whit object type #4996

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Apr 8, 2020

close #4981

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4981

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 8, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #4996 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4996      +/-   ##
==========================================
- Coverage   91.48%   91.46%   -0.02%     
==========================================
  Files         548      548              
  Lines       13771    13775       +4     
  Branches     2044     2045       +1     
==========================================
+ Hits        12598    12599       +1     
- Misses        710      714       +4     
+ Partials      463      462       -1     
Impacted Files Coverage Δ
...ts/auto-complete/autocomplete-trigger.directive.ts 95.75% <100.00%> (+0.05%) ⬆️
components/auto-complete/autocomplete.component.ts 94.28% <100.00%> (+0.11%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df01bd1...e115bb9. Read the comment docs.

@vthinkxie vthinkxie merged commit 4bfbbf7 into NG-ZORRO:master Apr 26, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a value in autocomplete doesn't show the label - only the raw value
3 participants