Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): fix input group missing focus and disabled #5082

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

vthinkxie
Copy link
Member

close #5064

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 20, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #5082 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5082   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         550      550           
  Lines       13736    13762   +26     
  Branches     2124     2125    +1     
=======================================
+ Hits        12565    12589   +24     
- Misses        709      710    +1     
- Partials      462      463    +1     
Impacted Files Coverage Δ
components/input/input-group.component.ts 100.00% <100.00%> (ø)
components/input/input.directive.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565b530...f9e0082. Read the comment docs.

@vthinkxie vthinkxie force-pushed the fix-input-group branch 2 times, most recently from 8f9e077 to 6d4500d Compare April 20, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.0.1 版本的 nz-input-group 使用 nzPrefix/nzSuffix 时缺少 focus 样式
2 participants