Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:message): fix message remove error when no container #5123

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

vthinkxie
Copy link
Member

close #5121

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #5123 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5123      +/-   ##
==========================================
- Coverage   91.45%   91.45%   -0.01%     
==========================================
  Files         547      547              
  Lines       13746    13747       +1     
  Branches     2129     2130       +1     
==========================================
  Hits        12572    12572              
  Misses        709      709              
- Partials      465      466       +1     
Impacted Files Coverage Δ
components/message/base.ts 88.78% <75.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82618c2...2304a5b. Read the comment docs.

@vthinkxie vthinkxie merged commit 1eca795 into NG-ZORRO:master Apr 24, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NzMessageService.remove(id=undefined) in 9.x fails on blank slate
2 participants