Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:space): fix config name #5147

Merged
merged 1 commit into from
Apr 25, 2020
Merged

fix(module:space): fix config name #5147

merged 1 commit into from
Apr 25, 2020

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #5147 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5147      +/-   ##
==========================================
- Coverage   91.44%   91.43%   -0.01%     
==========================================
  Files         547      547              
  Lines       13757    13757              
  Branches     2132     2132              
==========================================
- Hits        12580    12579       -1     
- Misses        711      712       +1     
  Partials      466      466              
Impacted Files Coverage Δ
components/space/space.component.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a9d34...926a779. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 64f772d into NG-ZORRO:master Apr 25, 2020
@danranVm danranVm deleted the dev-fix-space branch April 25, 2020 14:36
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants