Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix cascader position #5148

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 25, 2020

close #5102

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #5148 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5148   +/-   ##
=======================================
  Coverage   91.46%   91.47%           
=======================================
  Files         547      547           
  Lines       13747    13768   +21     
  Branches     2130     2137    +7     
=======================================
+ Hits        12574    12594   +20     
+ Misses        708      707    -1     
- Partials      465      467    +2     
Impacted Files Coverage Δ
components/core/overlay/overlay-position.ts 90.90% <100.00%> (ø)
...s/notification/notification-container.component.ts 94.23% <0.00%> (-5.77%) ⬇️
components/select/select.module.ts 100.00% <0.00%> (ø)
components/select/select.component.ts 90.60% <0.00%> (ø)
components/descriptions/descriptions.component.ts 100.00% <0.00%> (ø)
components/date-picker/date-picker.component.ts 96.47% <0.00%> (+0.07%) ⬆️
components/form/form-control.component.ts 95.08% <0.00%> (+0.21%) ⬆️
components/select/option-container.component.ts 91.66% <0.00%> (+0.75%) ⬆️
components/select/select-search.component.ts 87.50% <0.00%> (+1.13%) ⬆️
components/table/src/table-data.service.ts 81.25% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eca795...b0e6a50. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

试了一下demo,好像没有生效

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 7870e67 into NG-ZORRO:master Apr 26, 2020
@wzhudev wzhudev deleted the cascader-position branch April 26, 2020 09:03
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:cascader): fix cascader position

close NG-ZORRO#5102

* fix: fix cascader style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader级联选择选择框在屏幕右边是会被屏幕挡住
3 participants