-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): option item not selected with falsy value #5264
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5264 +/- ##
==========================================
- Coverage 91.32% 91.31% -0.02%
==========================================
Files 551 551
Lines 13908 13908
Branches 2099 2099
==========================================
- Hits 12702 12700 -2
- Misses 713 717 +4
+ Partials 493 491 -2
Continue to review full report at Codecov.
|
@diyews Seems right to me, you should also add a unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@diyews Thanks! |
@wenqi73 I can provide an unit test commit if need. |
@diyews That will be great! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nz-select selected falsy value (eg.0) doesn't have the selected class
https://stackblitz.com/edit/angular-8iudzt
Issue Number: N/A
What is the new behavior?
Selected falsy value should have the selected class
Does this PR introduce a breaking change?
Other information